From 3bf1125619ea97511626b7af56c97ed07863c67c Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 14 Oct 2015 12:59:37 +0000 Subject: lldb-server: add support for binary memory reads Summary: This commit adds support for binary memory reads ($x) to lldb-server. It also removes the "0x" prefix from the $x client packet, to make it more compatible with the old $m packet. This allows us to use almost the same code for handling both packet types. I have verified that debugserver correctly handles $x packets even without the leading "0x". I have added a test which verifies that the stub returns the same memory contents for both kinds of memory reads ($x and $m). Reviewers: tberghammer, jasonmolenda Subscribers: iancottrell, lldb-commits Differential Revision: http://reviews.llvm.org/D13695 llvm-svn: 250295 --- lldb/source/Utility/StringExtractorGDBRemote.cpp | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'lldb/source/Utility/StringExtractorGDBRemote.cpp') diff --git a/lldb/source/Utility/StringExtractorGDBRemote.cpp b/lldb/source/Utility/StringExtractorGDBRemote.cpp index 03daabca3df..7c09b7a5d04 100644 --- a/lldb/source/Utility/StringExtractorGDBRemote.cpp +++ b/lldb/source/Utility/StringExtractorGDBRemote.cpp @@ -310,6 +310,12 @@ StringExtractorGDBRemote::GetServerPacketType () const case 'S': return eServerPacketType_S; + case 'x': + return eServerPacketType_x; + + case 'X': + return eServerPacketType_X; + case 'T': return eServerPacketType_T; -- cgit v1.2.3