From 5df78fa35b75e51014884ec5eae7fc0ff83f7dd8 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Sat, 23 May 2015 03:54:53 +0000 Subject: Did some cleanup to stop us from leaking Pipe file descriptors. The main issue was the Communication::Disconnect() was calling its Connection::Disconnect() but this wouldn't release the pipes that the ConnectionFileDescriptor was using. We also have someone that is holding a strong reference to the Process so that when you re-run, target replaces its m_process_sp, but it doesn't get destructed because someone has a strong reference to it. I need to track that down. But, even if we have a strong reference to the a process that is outstanding, we need to call Process::Finalize() to have it release as much of its resources as possible to avoid memory bloat. Removed the ProcessGDBRemote::SetExitStatus() override and replaced it with ProcessGDBRemote::DidExit(). Now we aren't leaking file descriptors and the stand alone test suite should run much better. llvm-svn: 238089 --- lldb/source/Target/Process.cpp | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) (limited to 'lldb/source/Target/Process.cpp') diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp index a78979cc701..896fb3fedda 100644 --- a/lldb/source/Target/Process.cpp +++ b/lldb/source/Target/Process.cpp @@ -1466,9 +1466,24 @@ Process::SetExitStatus (int status, const char *cstr) m_exit_string.clear(); } - DidExit (); + // When we exit, we no longer need to the communication channel + m_stdio_communication.StopReadThread(); + m_stdio_communication.Disconnect(); + m_stdin_forward = false; + + // And we don't need the input reader anymore as well + if (m_process_input_reader) + { + m_process_input_reader->SetIsDone(true); + m_process_input_reader->Cancel(); + m_process_input_reader.reset(); + } SetPrivateState (eStateExited); + + // Allow subclasses to do some cleanup + DidExit (); + return true; } -- cgit v1.2.3