From 34cda14b09e0e55f59ce374265207d9af04d27be Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 31 May 2018 09:46:26 +0000 Subject: Remove append parameter to FindGlobalVariables Summary: As discussed in https://bugs.llvm.org/show_bug.cgi?id=37317, FindGlobalVariables does not properly handle the case where append=false. As this doesn't seem to be used in the tree, this patch removes the parameter entirely. Reviewers: clayborg, jingham, labath Reviewed By: clayborg Subscribers: aprantl, lldb-commits, kubamracek, JDevlieghere Differential Revision: https://reviews.llvm.org/D46885 Patch by Tom Tromey . llvm-svn: 333639 --- lldb/source/Symbol/SymbolFile.cpp | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'lldb/source/Symbol/SymbolFile.cpp') diff --git a/lldb/source/Symbol/SymbolFile.cpp b/lldb/source/Symbol/SymbolFile.cpp index c532cadf6be..6b4da9c5300 100644 --- a/lldb/source/Symbol/SymbolFile.cpp +++ b/lldb/source/Symbol/SymbolFile.cpp @@ -96,19 +96,16 @@ uint32_t SymbolFile::ResolveSymbolContext(const FileSpec &file_spec, return 0; } -uint32_t SymbolFile::FindGlobalVariables( - const ConstString &name, const CompilerDeclContext *parent_decl_ctx, - bool append, uint32_t max_matches, VariableList &variables) { - if (!append) - variables.Clear(); +uint32_t +SymbolFile::FindGlobalVariables(const ConstString &name, + const CompilerDeclContext *parent_decl_ctx, + uint32_t max_matches, VariableList &variables) { return 0; } uint32_t SymbolFile::FindGlobalVariables(const RegularExpression ®ex, - bool append, uint32_t max_matches, + uint32_t max_matches, VariableList &variables) { - if (!append) - variables.Clear(); return 0; } -- cgit v1.2.3