From 03819d1c80ad5d7b34f8fe0d375fcd2ef6aa5e7f Mon Sep 17 00:00:00 2001 From: Lawrence D'Anna Date: Thu, 17 Oct 2019 22:22:09 +0000 Subject: eliminate one form of PythonObject::Reset() Summary: I'd like to eliminate all forms of Reset() and all public constructors on these objects, so the only way to make them is with Take<> and Retain<> and the only way to copy or move them is with actual c++ copy, move, or assignment. This is a simple place to start. Reviewers: JDevlieghere, clayborg, labath, jingham Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D69080 llvm-svn: 375182 --- lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp') diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp index 3ac404b532d..1fb9355b9ee 100644 --- a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp +++ b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp @@ -410,7 +410,7 @@ void PythonString::SetString(llvm::StringRef string) { llvm::consumeError(s.takeError()); Reset(); } else { - PythonObject::Reset(std::move(s.get())); + *this = std::move(s.get()); } } -- cgit v1.2.3