From d28b99374f174cc2da6657c876ab4f350e6e0fba Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Sat, 28 Sep 2013 15:23:41 +0000 Subject: * mktemp is insecure as it always creates or uses insecure temporary file. Switch to mkstemp. * Get and display the error message when an error occurs while creating the temporary file llvm-svn: 191616 --- .../Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp') diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp index dd161395601..47223f14575 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp @@ -7,6 +7,7 @@ // //===----------------------------------------------------------------------===// +#include #include "GDBRemoteCommunicationServer.h" #include "lldb/Core/StreamGDBRemote.h" @@ -762,9 +763,9 @@ GDBRemoteCommunicationServer::Handle_qLaunchGDBServer (StringExtractorGDBRemote Error error; std::string hostname; char unix_socket_name[PATH_MAX] = "/tmp/XXXXXX"; - if (::mktemp (unix_socket_name) == NULL) + if (::mkstemp (unix_socket_name) == -1) { - error.SetErrorString ("failed to make temporary path for a unix socket"); + error.SetErrorStringWithFormat("failed to make temporary path for a unix socket with errno: %s", strerror(errno)); } else { -- cgit v1.2.3