From 54782db7bce77387a63898c536d6aefb590cd7c0 Mon Sep 17 00:00:00 2001 From: Ewan Crawford Date: Wed, 16 Sep 2015 10:02:57 +0000 Subject: Add names to RenderScript kernel breakpoints. Use Breakpoint::AddName to mark all RenderScript kernel breakpoints with the name 'RenderScriptKernel'. Also update logging channels to include LIBLLDB_LOG_BREAKPOINT where appropriate. llvm-svn: 247782 --- .../RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp') diff --git a/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp b/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp index 9289efa068d..8146eaa03c6 100644 --- a/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp +++ b/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp @@ -838,7 +838,7 @@ RenderScriptRuntime::BreakOnModuleKernels(const RSModuleDescriptorSP rsmodule_sp void RenderScriptRuntime::SetBreakAllKernels(bool do_break, TargetSP target) { - Log* log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_LANGUAGE)); + Log* log(GetLogIfAnyCategoriesSet(LIBLLDB_LOG_LANGUAGE | LIBLLDB_LOG_BREAKPOINTS)); InitSearchFilter(target); @@ -868,7 +868,7 @@ RenderScriptRuntime::SetBreakAllKernels(bool do_break, TargetSP target) BreakpointSP RenderScriptRuntime::CreateKernelBreakpoint(const ConstString& name) { - Log* log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_LANGUAGE)); + Log* log(GetLogIfAnyCategoriesSet(LIBLLDB_LOG_LANGUAGE | LIBLLDB_LOG_BREAKPOINTS)); if (!m_filtersp) { @@ -880,6 +880,11 @@ RenderScriptRuntime::CreateKernelBreakpoint(const ConstString& name) BreakpointResolverSP resolver_sp(new RSBreakpointResolver(nullptr, name)); BreakpointSP bp = GetProcess()->GetTarget().CreateBreakpoint(m_filtersp, resolver_sp, false, false, false); + // Give RS breakpoints a specific name, so the user can manipulate them as a group. + Error err; + if (!bp->AddName("RenderScriptKernel", err) && log) + log->Printf("RenderScriptRuntime::CreateKernelBreakpoint: Error setting break name, %s", err.AsCString()); + return bp; } -- cgit v1.2.3