From 3ad8278737d042c6b5b61c0143ee68db66be91fe Mon Sep 17 00:00:00 2001 From: Raphael Isemann Date: Wed, 11 Sep 2019 14:33:11 +0000 Subject: [lldb][NFC] Make include directories in Clang expression parser a std::string We never compare these directories (where ConstString would be good) and essentially just convert this back to a normal string in the end. So we might as well just use std::string. Also makes it easier to unittest this code (which was the main motivation for this change). llvm-svn: 371623 --- lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp') diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp index 54d852b2d83..57bf654528a 100644 --- a/lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp +++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp @@ -469,7 +469,7 @@ ClangUserExpression::GetModulesToImport(ExecutionContext &exe_ctx) { } for (const SourceModule &m : sc.comp_unit->GetImportedModules()) - m_include_directories.push_back(m.search_path); + m_include_directories.emplace_back(m.search_path.GetCString()); // Check if we imported 'std' or any of its submodules. // We currently don't support importing any other modules in the expression -- cgit v1.2.3