From c7bece56faa5eef1c3d141d0c0b0b68b28a9aed2 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Fri, 25 Jan 2013 18:06:21 +0000 Subject: Major fixed to allow reading files that are over 4GB. The main problems were that the DataExtractor was using 32 bit offsets as a data cursor, and since we mmap all of our object files we could run into cases where if we had a very large core file that was over 4GB, we were running into the 4GB boundary. So I defined a new "lldb::offset_t" which should be used for all file offsets. After making this change, I enabled warnings for data loss and for enexpected implicit conversions temporarily and found a ton of things that I fixed. Any functions that take an index internally, should use "size_t" for any indexes and also should return "size_t" for any sizes of collections. llvm-svn: 173463 --- lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp | 8 ++++---- lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'lldb/source/Plugins/Disassembler') diff --git a/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp b/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp index 7522a1ced16..ec715293bd1 100644 --- a/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp +++ b/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp @@ -68,7 +68,7 @@ public: virtual size_t Decode (const lldb_private::Disassembler &disassembler, const lldb_private::DataExtractor &data, - uint32_t data_offset) + lldb::offset_t data_offset) { // All we have to do is read the opcode which can be easy for some // architetures @@ -239,7 +239,7 @@ public: m_comment.assign ("unknown opcode"); inst_size = m_opcode.GetByteSize(); StreamString mnemonic_strm; - uint32_t offset = 0; + lldb::offset_t offset = 0; switch (inst_size) { case 1: @@ -486,8 +486,8 @@ DisassemblerLLVMC::~DisassemblerLLVMC() size_t DisassemblerLLVMC::DecodeInstructions (const Address &base_addr, const DataExtractor& data, - uint32_t data_offset, - uint32_t num_instructions, + lldb::offset_t data_offset, + size_t num_instructions, bool append) { if (!append) diff --git a/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.h b/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.h index 5f9bcc837ee..c6c3e6652bb 100644 --- a/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.h +++ b/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.h @@ -50,8 +50,8 @@ public: size_t DecodeInstructions (const lldb_private::Address &base_addr, const lldb_private::DataExtractor& data, - uint32_t data_offset, - uint32_t num_instructions, + lldb::offset_t data_offset, + size_t num_instructions, bool append); //------------------------------------------------------------------ -- cgit v1.2.3