From 1080edbcdd7d24ad5213749e396e23b54c1a3040 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Fri, 25 Mar 2011 18:03:16 +0000 Subject: Cleaned up the Disassembler code a bit more. You can now request a disassembler plugin by name on the command line for when there is more than one disassembler plugin. Taught the Opcode class to dump itself so that "disassembler -b" will dump the bytes correctly for each opcode type. Modified all places that were passing the opcode bytes buffer in so that the bytes could be displayed to just pass in a bool that indicates if we should dump the opcode bytes since the opcode now lives inside llvm_private::Instruction. llvm-svn: 128290 --- lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVM.h | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVM.h') diff --git a/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVM.h b/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVM.h index 5ecda3e7014..9e01bf3f2c6 100644 --- a/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVM.h +++ b/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVM.h @@ -28,21 +28,17 @@ public: virtual ~InstructionLLVM(); - void + virtual void Dump (lldb_private::Stream *s, bool show_address, - const lldb_private::DataExtractor *bytes, - uint32_t bytes_offset, + bool show_bytes, const lldb_private::ExecutionContext* exe_ctx, bool raw); - bool + virtual bool DoesBranch () const; - size_t - GetByteSize() const; - - size_t + virtual size_t Extract (const Disassembler &disassembler, const lldb_private::DataExtractor &data, uint32_t data_offset); -- cgit v1.2.3