From 41af43092ccc8030bb49cea324d85eecd5ae68a8 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 11 Nov 2016 04:28:40 +0000 Subject: Make the Error class constructor protected This is forcing to use Error::success(), which is in a wide majority of cases a lot more readable. Differential Revision: https://reviews.llvm.org/D26481 llvm-svn: 286561 --- lldb/source/Host/windows/PipeWindows.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lldb/source/Host/windows/PipeWindows.cpp') diff --git a/lldb/source/Host/windows/PipeWindows.cpp b/lldb/source/Host/windows/PipeWindows.cpp index 407f0468e6c..64b65847506 100644 --- a/lldb/source/Host/windows/PipeWindows.cpp +++ b/lldb/source/Host/windows/PipeWindows.cpp @@ -161,7 +161,7 @@ Error PipeWindows::OpenNamedPipe(llvm::StringRef name, ZeroMemory(&m_write_overlapped, sizeof(m_write_overlapped)); } - return Error(); + return Error::success(); } int PipeWindows::GetReadFileDescriptor() const { return m_read_fd; } @@ -217,7 +217,7 @@ void PipeWindows::Close() { CloseWriteFileDescriptor(); } -Error PipeWindows::Delete(llvm::StringRef name) { return Error(); } +Error PipeWindows::Delete(llvm::StringRef name) { return Error::success(); } bool PipeWindows::CanRead() const { return (m_read != INVALID_HANDLE_VALUE); } @@ -273,7 +273,7 @@ Error PipeWindows::ReadWithTimeout(void *buf, size_t size, return Error(::GetLastError(), eErrorTypeWin32); bytes_read = sys_bytes_read; - return Error(); + return Error::success(); } Error PipeWindows::Write(const void *buf, size_t num_bytes, @@ -291,5 +291,5 @@ Error PipeWindows::Write(const void *buf, size_t num_bytes, &sys_bytes_written, TRUE); if (!result) return Error(::GetLastError(), eErrorTypeWin32); - return Error(); + return Error::success(); } -- cgit v1.2.3