From c7bece56faa5eef1c3d141d0c0b0b68b28a9aed2 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Fri, 25 Jan 2013 18:06:21 +0000 Subject: Major fixed to allow reading files that are over 4GB. The main problems were that the DataExtractor was using 32 bit offsets as a data cursor, and since we mmap all of our object files we could run into cases where if we had a very large core file that was over 4GB, we were running into the 4GB boundary. So I defined a new "lldb::offset_t" which should be used for all file offsets. After making this change, I enabled warnings for data loss and for enexpected implicit conversions temporarily and found a ton of things that I fixed. Any functions that take an index internally, should use "size_t" for any indexes and also should return "size_t" for any sizes of collections. llvm-svn: 173463 --- lldb/source/Host/common/File.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lldb/source/Host/common/File.cpp') diff --git a/lldb/source/Host/common/File.cpp b/lldb/source/Host/common/File.cpp index 7fd5dd67e91..ae0bf887974 100644 --- a/lldb/source/Host/common/File.cpp +++ b/lldb/source/Host/common/File.cpp @@ -625,12 +625,12 @@ File::Write (const void *buf, size_t &num_bytes, off_t &offset) //------------------------------------------------------------------ // Print some formatted output to the stream. //------------------------------------------------------------------ -int +size_t File::Printf (const char *format, ...) { va_list args; va_start (args, format); - int result = PrintfVarArg (format, args); + size_t result = PrintfVarArg (format, args); va_end (args); return result; } @@ -638,10 +638,10 @@ File::Printf (const char *format, ...) //------------------------------------------------------------------ // Print some formatted output to the stream. //------------------------------------------------------------------ -int +size_t File::PrintfVarArg (const char *format, va_list args) { - int result = 0; + size_t result = 0; if (DescriptorIsValid()) { char *s = NULL; -- cgit v1.2.3