From c7bece56faa5eef1c3d141d0c0b0b68b28a9aed2 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Fri, 25 Jan 2013 18:06:21 +0000 Subject: Major fixed to allow reading files that are over 4GB. The main problems were that the DataExtractor was using 32 bit offsets as a data cursor, and since we mmap all of our object files we could run into cases where if we had a very large core file that was over 4GB, we were running into the 4GB boundary. So I defined a new "lldb::offset_t" which should be used for all file offsets. After making this change, I enabled warnings for data loss and for enexpected implicit conversions temporarily and found a ton of things that I fixed. Any functions that take an index internally, should use "size_t" for any indexes and also should return "size_t" for any sizes of collections. llvm-svn: 173463 --- lldb/source/Expression/IRInterpreter.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lldb/source/Expression/IRInterpreter.cpp') diff --git a/lldb/source/Expression/IRInterpreter.cpp b/lldb/source/Expression/IRInterpreter.cpp index 2027556586a..a01e19165e1 100644 --- a/lldb/source/Expression/IRInterpreter.cpp +++ b/lldb/source/Expression/IRInterpreter.cpp @@ -506,7 +506,7 @@ public: size_t value_size = m_target_data.getTypeStoreSize(value->getType()); - uint32_t offset = 0; + lldb::offset_t offset = 0; uint64_t u64value = value_extractor->GetMaxU64(&offset, value_size); return AssignToMatchType(scalar, u64value, value->getType()); @@ -885,7 +885,7 @@ public: return false; Type *R_ty = pointer_ptr_ty->getElementType(); - uint32_t offset = 0; + lldb::offset_t offset = 0; lldb::addr_t pointer = P_extractor->GetAddress(&offset); Memory::Region R = m_memory.Lookup(pointer, R_ty); @@ -1693,7 +1693,7 @@ IRInterpreter::runOnFunction (lldb::ClangExpressionVariableSP &result, DataExtractorSP P_extractor(memory.GetExtractor(P)); DataEncoderSP D_encoder(memory.GetEncoder(D)); - uint32_t offset = 0; + lldb::offset_t offset = 0; lldb::addr_t pointer = P_extractor->GetAddress(&offset); Memory::Region R = memory.Lookup(pointer, target_ty); @@ -1806,7 +1806,7 @@ IRInterpreter::runOnFunction (lldb::ClangExpressionVariableSP &result, if (!P_extractor || !D_extractor) return false; - uint32_t offset = 0; + lldb::offset_t offset = 0; lldb::addr_t pointer = P_extractor->GetAddress(&offset); Memory::Region R = memory.Lookup(pointer, target_ty); -- cgit v1.2.3