From 5160ce5c72e5f55c2e83ca9914cd0f02e0c5ceb3 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 27 Mar 2013 23:08:40 +0000 Subject: LLDB is crashing when logging is enabled from lldb-perf-clang. This has to do with the global destructor chain as the process and its threads are being torn down. All logging channels now make one and only one instance that is kept in a global pointer which is never freed. This guarantees that logging can correctly continue as the process tears itself down. llvm-svn: 178191 --- lldb/source/DataFormatters/FormatManager.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lldb/source/DataFormatters/FormatManager.cpp') diff --git a/lldb/source/DataFormatters/FormatManager.cpp b/lldb/source/DataFormatters/FormatManager.cpp index fa9ce499f37..01f5d7f05cd 100644 --- a/lldb/source/DataFormatters/FormatManager.cpp +++ b/lldb/source/DataFormatters/FormatManager.cpp @@ -341,7 +341,7 @@ FormatManager::GetSummaryFormat (ValueObject& valobj, { TypeSummaryImplSP retval; #if USE_CACHE - LogSP log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_TYPES)); + Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_TYPES)); ConstString valobj_type(GetTypeForCache(valobj, use_dynamic)); if (valobj_type) { @@ -376,7 +376,7 @@ FormatManager::GetSyntheticChildren (ValueObject& valobj, { SyntheticChildrenSP retval; #if USE_CACHE - LogSP log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_TYPES)); + Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_TYPES)); ConstString valobj_type(GetTypeForCache(valobj, use_dynamic)); if (valobj_type) { -- cgit v1.2.3