From 34cda14b09e0e55f59ce374265207d9af04d27be Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 31 May 2018 09:46:26 +0000 Subject: Remove append parameter to FindGlobalVariables Summary: As discussed in https://bugs.llvm.org/show_bug.cgi?id=37317, FindGlobalVariables does not properly handle the case where append=false. As this doesn't seem to be used in the tree, this patch removes the parameter entirely. Reviewers: clayborg, jingham, labath Reviewed By: clayborg Subscribers: aprantl, lldb-commits, kubamracek, JDevlieghere Differential Revision: https://reviews.llvm.org/D46885 Patch by Tom Tromey . llvm-svn: 333639 --- lldb/source/Core/Module.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'lldb/source/Core/Module.cpp') diff --git a/lldb/source/Core/Module.cpp b/lldb/source/Core/Module.cpp index b6b89078491..e586a628321 100644 --- a/lldb/source/Core/Module.cpp +++ b/lldb/source/Core/Module.cpp @@ -599,21 +599,21 @@ uint32_t Module::ResolveSymbolContextsForFileSpec(const FileSpec &file_spec, size_t Module::FindGlobalVariables(const ConstString &name, const CompilerDeclContext *parent_decl_ctx, - bool append, size_t max_matches, + size_t max_matches, VariableList &variables) { SymbolVendor *symbols = GetSymbolVendor(); if (symbols) - return symbols->FindGlobalVariables(name, parent_decl_ctx, append, - max_matches, variables); + return symbols->FindGlobalVariables(name, parent_decl_ctx, max_matches, + variables); return 0; } -size_t Module::FindGlobalVariables(const RegularExpression ®ex, bool append, +size_t Module::FindGlobalVariables(const RegularExpression ®ex, size_t max_matches, VariableList &variables) { SymbolVendor *symbols = GetSymbolVendor(); if (symbols) - return symbols->FindGlobalVariables(regex, append, max_matches, variables); + return symbols->FindGlobalVariables(regex, max_matches, variables); return 0; } -- cgit v1.2.3