From c7bece56faa5eef1c3d141d0c0b0b68b28a9aed2 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Fri, 25 Jan 2013 18:06:21 +0000 Subject: Major fixed to allow reading files that are over 4GB. The main problems were that the DataExtractor was using 32 bit offsets as a data cursor, and since we mmap all of our object files we could run into cases where if we had a very large core file that was over 4GB, we were running into the 4GB boundary. So I defined a new "lldb::offset_t" which should be used for all file offsets. After making this change, I enabled warnings for data loss and for enexpected implicit conversions temporarily and found a ton of things that I fixed. Any functions that take an index internally, should use "size_t" for any indexes and also should return "size_t" for any sizes of collections. llvm-svn: 173463 --- lldb/source/Core/Debugger.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'lldb/source/Core/Debugger.cpp') diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp index 2a296dba15b..e7e0e203f4d 100644 --- a/lldb/source/Core/Debugger.cpp +++ b/lldb/source/Core/Debugger.cpp @@ -999,7 +999,7 @@ Debugger::GetAsyncErrorStream () CommandInterpreter::eBroadcastBitAsynchronousErrorData)); } -uint32_t +size_t Debugger::GetNumDebuggers() { if (g_shared_debugger_refcount > 0) @@ -1011,7 +1011,7 @@ Debugger::GetNumDebuggers() } lldb::DebuggerSP -Debugger::GetDebuggerAtIndex (uint32_t index) +Debugger::GetDebuggerAtIndex (size_t index) { DebuggerSP debugger_sp; @@ -1228,7 +1228,7 @@ ScanBracketedRange (const char* var_name_begin, { if (log) log->Printf("[ScanBracketedRange] swapping indices"); - int temp = *index_lower; + int64_t temp = *index_lower; *index_lower = *index_higher; *index_higher = temp; } @@ -1240,7 +1240,7 @@ ScanBracketedRange (const char* var_name_begin, static ValueObjectSP ExpandIndexedExpression (ValueObject* valobj, - uint32_t index, + size_t index, StackFrame* frame, bool deref_pointer) { @@ -2539,8 +2539,7 @@ Debugger::FormatPrompt unsigned long octal_value = ::strtoul (oct_str, NULL, 8); if (octal_value <= UINT8_MAX) { - char octal_char = octal_value; - s.Write (&octal_char, 1); + s.PutChar((char)octal_value); } } break; @@ -2563,7 +2562,7 @@ Debugger::FormatPrompt unsigned long hex_value = strtoul (hex_str, NULL, 16); if (hex_value <= UINT8_MAX) - s.PutChar (hex_value); + s.PutChar ((char)hex_value); } else { -- cgit v1.2.3