From 12cecd741d8a8069b81fbc9021610b92d1fceb7b Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Mon, 20 Sep 2010 21:37:42 +0000 Subject: Make GetInstanceSettingsValue methods take an Error * rather than an Error &, and have them return a bool to indicate success or not. llvm-svn: 114361 --- lldb/source/Core/Debugger.cpp | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'lldb/source/Core/Debugger.cpp') diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp index 6bce57ae103..5ad5227be7a 100644 --- a/lldb/source/Core/Debugger.cpp +++ b/lldb/source/Core/Debugger.cpp @@ -1375,11 +1375,11 @@ DebuggerInstanceSettings::UpdateInstanceSettingsVariable (const ConstString &var } } -void +bool DebuggerInstanceSettings::GetInstanceSettingsValue (const SettingEntry &entry, const ConstString &var_name, StringList &value, - Error &err) + Error *err) { if (var_name == PromptVarName()) { @@ -1404,7 +1404,12 @@ DebuggerInstanceSettings::GetInstanceSettingsValue (const SettingEntry &entry, value.AppendString ("false"); } else - err.SetErrorStringWithFormat ("unrecognized variable name '%s'", var_name.AsCString()); + { + if (err) + err->SetErrorStringWithFormat ("unrecognized variable name '%s'", var_name.AsCString()); + return false; + } + return true; } void -- cgit v1.2.3