From b2575da9aa3f759206bf762ad2ceb7fc1946f0f6 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 17 Oct 2019 00:01:57 +0000 Subject: [Reproducer] Add LoadBuffer<> helper (NFC) Introduce a helper method named LoadBuffer in the Loader to abstract reading a reproducer file from disk. llvm-svn: 375060 --- lldb/source/Commands/CommandObjectReproducer.cpp | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) (limited to 'lldb/source/Commands') diff --git a/lldb/source/Commands/CommandObjectReproducer.cpp b/lldb/source/Commands/CommandObjectReproducer.cpp index 424595fc0bd..0c2e95d5d21 100644 --- a/lldb/source/Commands/CommandObjectReproducer.cpp +++ b/lldb/source/Commands/CommandObjectReproducer.cpp @@ -265,19 +265,12 @@ protected: return true; } case eReproducerProviderVersion: { - FileSpec version_file = loader->GetFile(); - - // Load the version info into a buffer. - ErrorOr> buffer = - vfs::getRealFileSystem()->getBufferForFile(version_file.GetPath()); - if (!buffer) { - SetError(result, errorCodeToError(buffer.getError())); + Expected version = loader->LoadBuffer(); + if (!version) { + SetError(result, version.takeError()); return false; } - - // Return the version string. - StringRef version = (*buffer)->getBuffer(); - result.AppendMessage(version.str()); + result.AppendMessage(*version); result.SetStatus(eReturnStatusSuccessFinishResult); return true; } -- cgit v1.2.3