From c7bece56faa5eef1c3d141d0c0b0b68b28a9aed2 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Fri, 25 Jan 2013 18:06:21 +0000 Subject: Major fixed to allow reading files that are over 4GB. The main problems were that the DataExtractor was using 32 bit offsets as a data cursor, and since we mmap all of our object files we could run into cases where if we had a very large core file that was over 4GB, we were running into the 4GB boundary. So I defined a new "lldb::offset_t" which should be used for all file offsets. After making this change, I enabled warnings for data loss and for enexpected implicit conversions temporarily and found a ton of things that I fixed. Any functions that take an index internally, should use "size_t" for any indexes and also should return "size_t" for any sizes of collections. llvm-svn: 173463 --- lldb/source/Commands/CommandObjectRegister.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'lldb/source/Commands/CommandObjectRegister.cpp') diff --git a/lldb/source/Commands/CommandObjectRegister.cpp b/lldb/source/Commands/CommandObjectRegister.cpp index db1c3af1862..79a76fbaed9 100644 --- a/lldb/source/Commands/CommandObjectRegister.cpp +++ b/lldb/source/Commands/CommandObjectRegister.cpp @@ -129,7 +129,7 @@ public: DumpRegisterSet (const ExecutionContext &exe_ctx, Stream &strm, RegisterContext *reg_ctx, - uint32_t set_idx, + size_t set_idx, bool primitive_only=false) { uint32_t unavailable_count = 0; @@ -139,8 +139,8 @@ public: { strm.Printf ("%s:\n", reg_set->name); strm.IndentMore (); - const uint32_t num_registers = reg_set->num_registers; - for (uint32_t reg_idx = 0; reg_idx < num_registers; ++reg_idx) + const size_t num_registers = reg_set->num_registers; + for (size_t reg_idx = 0; reg_idx < num_registers; ++reg_idx) { const uint32_t reg = reg_set->registers[reg_idx]; const RegisterInfo *reg_info = reg_ctx->GetRegisterInfoAtIndex(reg); @@ -173,20 +173,20 @@ protected: const RegisterInfo *reg_info = NULL; if (command.GetArgumentCount() == 0) { - uint32_t set_idx; + size_t set_idx; - uint32_t num_register_sets = 1; - const uint32_t set_array_size = m_command_options.set_indexes.GetSize(); + size_t num_register_sets = 1; + const size_t set_array_size = m_command_options.set_indexes.GetSize(); if (set_array_size > 0) { - for (uint32_t i=0; iGetUInt64Value (UINT32_MAX, NULL); if (set_idx != UINT32_MAX) { if (!DumpRegisterSet (m_exe_ctx, strm, reg_ctx, set_idx)) { - result.AppendErrorWithFormat ("invalid register set index: %u\n", set_idx); + result.AppendErrorWithFormat ("invalid register set index: %zu\n", set_idx); result.SetStatus (eReturnStatusFailed); break; } -- cgit v1.2.3