From 7f5237bccc27103c2718139e8316f14028ca9a5e Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 11 Mar 2019 13:58:46 +0000 Subject: Add "operator bool" to SB APIs Summary: Our python version of the SB API has (the python equivalent of) operator bool, but the C++ version doesn't. This is because our python operators are added by modify-python-lldb.py, which performs postprocessing on the swig-generated interface files. In this patch, I add the "operator bool" to all SB classes which have an IsValid method (which is the same logic used by modify-python-lldb.py). This way, we make the two interfaces more constent, and it allows us to rely on swig's automatic syntesis of python __nonzero__ methods instead of doing manual fixups. Reviewers: zturner, jingham, clayborg, jfb, serge-sans-paille Subscribers: jdoerfert, lldb-commits Differential Revision: https://reviews.llvm.org/D58792 llvm-svn: 355824 --- lldb/source/API/SBThreadCollection.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'lldb/source/API/SBThreadCollection.cpp') diff --git a/lldb/source/API/SBThreadCollection.cpp b/lldb/source/API/SBThreadCollection.cpp index b9c1e755468..90c5f810200 100644 --- a/lldb/source/API/SBThreadCollection.cpp +++ b/lldb/source/API/SBThreadCollection.cpp @@ -62,6 +62,10 @@ const lldb::ThreadCollectionSP &SBThreadCollection::operator*() const { bool SBThreadCollection::IsValid() const { LLDB_RECORD_METHOD_CONST_NO_ARGS(bool, SBThreadCollection, IsValid); + return this->operator bool(); +} +SBThreadCollection::operator bool() const { + LLDB_RECORD_METHOD_CONST_NO_ARGS(bool, SBThreadCollection, operator bool); return m_opaque_sp.get() != NULL; } -- cgit v1.2.3