From d6f903f05c8eaa5ad4f290f016daf84e06349901 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 19 Feb 2018 13:53:12 +0000 Subject: Make gdb-client tests generate binaries in the build tree These were missed in the great refactor because they were added concurrently with it. Since we started running tests in a more parallel fashion they started to be flaky. This should fix it. Now that we are no longer polluting the source tree, I also delete the bit of custom cleanup code specific to these tests. llvm-svn: 325495 --- .../test/functionalities/gdb_remote_client/gdbclientutils.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'lldb/packages/Python') diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py index 7d19d2cf920..e3242295aad 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py @@ -392,24 +392,19 @@ class GDBRemoteTestBase(TestBase): NO_DEBUG_INFO_TESTCASE = True mydir = TestBase.compute_mydir(__file__) server = None - temp_files = None def setUp(self): TestBase.setUp(self) - self.temp_files = [] self.server = MockGDBServer() self.server.start() def tearDown(self): - for temp_file in self.temp_files: - self.RemoveTempFile(temp_file) # TestBase.tearDown will kill the process, but we need to kill it early # so its client connection closes and we can stop the server before # finally calling the base tearDown. if self.process() is not None: self.process().Kill() self.server.stop() - self.temp_files = [] TestBase.tearDown(self) def createTarget(self, yaml_path): @@ -421,9 +416,8 @@ class GDBRemoteTestBase(TestBase): during tearDown. """ yaml_base, ext = os.path.splitext(yaml_path) - obj_path = "%s" % yaml_base + obj_path = self.getBuildArtifact(yaml_base) self.yaml2obj(yaml_path, obj_path) - self.temp_files.append(obj_path) return self.dbg.CreateTarget(obj_path) def connect(self, target): -- cgit v1.2.3