From 60ab30ebce833c87bd4776f67cd9a82fe162ef9c Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Fri, 8 Nov 2019 18:20:27 -0800 Subject: Temporarily change the default for use-g-packet-for-reading to false, until we can automatically fall back to p/P if g/G are not supported; it looks like there is a bug in debugserver's g/G packets taht needs to be fixed, or debugserver should stop supporting g/G until that bug is fixed. But we need lldb to be able to fall back to p/P correctly for that to be a viable workaround. --- .../test/functionalities/gdb_remote_client/TestGDBRemoteClient.py | 4 ++++ .../test/functionalities/gdb_remote_client/TestNoGPacketSupported.py | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) (limited to 'lldb/packages/Python') diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py index fd13b1f2cd6..8f0ed9a4933 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py @@ -52,6 +52,10 @@ class TestGDBRemoteClient(GDBRemoteTestBase): def test_read_registers_using_g_packets(self): """Test reading registers using 'g' packets (default behavior)""" + self.dbg.HandleCommand( + "settings set plugin.process.gdb-remote.use-g-packet-for-reading true") + self.addTearDownHook(lambda: + self.runCmd("settings set plugin.process.gdb-remote.use-g-packet-for-reading false")) self.server.responder = self.gPacketResponder() target = self.createTarget("a.yaml") process = self.connect(target) diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py index b2236768203..989684c6222 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py @@ -23,7 +23,6 @@ from gdbclientutils import * class TestNoGPacketSupported(GDBRemoteTestBase): @skipIfXmlSupportMissing - @expectedFailureAll def test(self): class MyResponder(MockGDBServerResponder): def haltReason(self): -- cgit v1.2.3