From 5a48f95a0f4428336d9d7732a961fd09bb411839 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 14 Mar 2018 09:13:33 +0000 Subject: Skip TestWatchedVarHitWhenInScope.py everywhere The expression-hits tracking logic is not available on any platform. The reason this tests happens to pass on some platforms is that the test is written poorly -- it relies on the fact that post-main cleanup code will write to the stack memory once occupied by the watched variable, but this is not the case everywhere (e.g. linux glibc does not seem to do this, but android's bionic library does). llvm-svn: 327483 --- .../watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'lldb/packages/Python') diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py b/lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py index 1a8708736ca..b2f267364dd 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py @@ -23,8 +23,6 @@ class WatchedVariableHitWhenInScopeTestCase(TestBase): # but the way this was done was incorrect, and it is unclear that for the # most part that's not what folks mostly want, so we have to provide a # clearer API to express this. - # - # This functionality is currently unsupported on Darwin. def setUp(self): # Call super's setUp(). @@ -36,7 +34,7 @@ class WatchedVariableHitWhenInScopeTestCase(TestBase): # Test hangs due to a kernel bug, see fdfeff0f in the linux kernel for details @skipIfTargetAndroid(api_levels=list(range(25+1)), archs=["aarch64", "arm"]) - @skipIfDarwin + @skipIf def test_watched_var_should_only_hit_when_in_scope(self): """Test that a variable watchpoint should only hit when in scope.""" self.build(dictionary=self.d) -- cgit v1.2.3