From df225764b7d5d96ead8787bc7d1667160d8bbffe Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Thu, 9 May 2019 20:39:34 +0000 Subject: Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one Currently when we single step over a source line, we run and stop at every branch in the source line range. We can reduce the number of times we stop when stepping over by figuring out if any of these branches are function calls, and if so, ignore these branches. Since we are stepping over we can safely ignore these calls since they will return to the next instruction. Currently the step logic would stop at those branches (1st stop), single step into the branch (2nd stop), and then set a breakpoint at the return address (3rd stop), and then continue. Differential Revision: https://reviews.llvm.org/D58678 llvm-svn: 360375 --- .../breakpoint/require_hw_breakpoints/TestRequireHWBreakpoints.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'lldb/packages/Python/lldbsuite') diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/require_hw_breakpoints/TestRequireHWBreakpoints.py b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/require_hw_breakpoints/TestRequireHWBreakpoints.py index cda15fee84b..c0587946261 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/require_hw_breakpoints/TestRequireHWBreakpoints.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/require_hw_breakpoints/TestRequireHWBreakpoints.py @@ -79,12 +79,11 @@ class BreakpointLocationsTestCase(TestBase): self.runCmd("settings set target.require-hardware-breakpoint true") # Step over doesn't fail immediately but fails later on. - self.expect("thread step-over") self.expect( - "process status", + "thread step-over", + error=True, substrs=[ - 'step over failed', - 'Could not create hardware breakpoint for thread plan' + 'error: Could not create hardware breakpoint for thread plan.' ]) @skipIfWindows -- cgit v1.2.3