From 94bd575c73f60de157a0e7103d76d50ee7d7d1de Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 21 Oct 2016 00:06:38 +0000 Subject: Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands. Also, watchpoint commands, like breakpoint commands, need to run in async mode. This was causing intermittent failures in TestWatchpointCommandPython.py, which is now solid. llvm-svn: 284795 --- .../watchpoint_commands/command/TestWatchpointCommandPython.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'lldb/packages/Python/lldbsuite') diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py b/lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py index e6726f5792c..a6cc4f268e3 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py @@ -54,9 +54,6 @@ class WatchpointPythonCommandTestCase(TestBase): # Add a breakpoint to set a watchpoint when stopped on the breakpoint. lldbutil.run_break_set_by_file_and_line( self, None, self.line, num_expected_locations=1) -# self.expect("breakpoint set -l %d" % self.line, BREAKPOINT_CREATED, -# startstr = "Breakpoint created: 1: file ='%s', line = %d, locations = 1" % -# (self.source, self.line))# # Run the program. self.runCmd("run", RUN_SUCCEEDED) @@ -131,9 +128,6 @@ class WatchpointPythonCommandTestCase(TestBase): # Add a breakpoint to set a watchpoint when stopped on the breakpoint. lldbutil.run_break_set_by_file_and_line( self, None, self.line, num_expected_locations=1) -# self.expect("breakpoint set -l %d" % self.line, BREAKPOINT_CREATED, -# startstr = "Breakpoint created: 1: file ='%s', line = %d, locations = 1" % -# (self.source, self.line))# # Run the program. self.runCmd("run", RUN_SUCCEEDED) @@ -177,3 +171,4 @@ class WatchpointPythonCommandTestCase(TestBase): # second hit and set it to 999 self.expect("frame variable --show-globals cookie", substrs=['(int32_t)', 'cookie = 999']) + -- cgit v1.2.3