From 27a313ebde156f2db5f071a10444c9df8c332fc6 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Tue, 20 Aug 2019 21:58:22 +0000 Subject: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC) Summary: The test for conditional breakpoints on Windows was skipped because there was no expression evaluation support at the time it was written. After removing the annotation and testing it again, the test is passing. http://lists.llvm.org/pipermail/lldb-dev/2019-August/015405.html Signed-off-by: Med Ismail Bennani Reviewers: stella.stamenova, jingham Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D66499 llvm-svn: 369453 --- .../breakpoint/breakpoint_conditions/TestBreakpointConditions.py | 8 -------- 1 file changed, 8 deletions(-) (limited to 'lldb/packages/Python/lldbsuite') diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py index 060d45eac74..96ed32a9efe 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py @@ -15,30 +15,22 @@ class BreakpointConditionsTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) - # Requires EE to support COFF on Windows (http://llvm.org/pr22232) - @skipIfWindows def test_breakpoint_condition_and_run_command(self): """Exercise breakpoint condition with 'breakpoint modify -c id'.""" self.build() self.breakpoint_conditions() - # Requires EE to support COFF on Windows (http://llvm.org/pr22232) - @skipIfWindows def test_breakpoint_condition_inline_and_run_command(self): """Exercise breakpoint condition inline with 'breakpoint set'.""" self.build() self.breakpoint_conditions(inline=True) - # Requires EE to support COFF on Windows (http://llvm.org/pr22232) - @skipIfWindows @add_test_categories(['pyapi']) def test_breakpoint_condition_and_python_api(self): """Use Python APIs to set breakpoint conditions.""" self.build() self.breakpoint_conditions_python() - # Requires EE to support COFF on Windows (http://llvm.org/pr22232) - @skipIfWindows @add_test_categories(['pyapi']) def test_breakpoint_invalid_condition_and_python_api(self): """Use Python APIs to set breakpoint conditions.""" -- cgit v1.2.3