From 060bf99f493ea5515fa09dec8dc949dc6d57db09 Mon Sep 17 00:00:00 2001 From: Jorge Gorbe Moya Date: Wed, 3 Apr 2019 20:43:20 +0000 Subject: Re-enable most lldb-vscode tests on Linux. Summary: After https://reviews.llvm.org/D59828 and https://reviews.llvm.org/D59849, I believe the problems with these tests hanging have been solved. I tried enabling all of them on my machine, and got two failures: - One of them was spawning a child process that lives for 5 seconds, waited for 5 seconds to attach to the child, and failed because the child wasn't there. - The other one was a legit failure because shell expansion of arguments doesn't work on Linux. This tests enables all lldb-vscode tests on Linux except for "launch process with shell expansion of args" (which doesn't work), and fixes the other broken test by reducing the time it waits before attaching to its child process. Reviewers: zturner, clayborg Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D60153 llvm-svn: 357633 --- .../tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py | 2 -- 1 file changed, 2 deletions(-) (limited to 'lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint') diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py index a175b2f5ba6..8a3f3549f6e 100644 --- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py +++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py @@ -21,7 +21,6 @@ class TestVSCode_setFunctionBreakpoints( @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots - @skipIfLinux # test hangs on linux under heavy load @no_debug_info_test def test_set_and_clear(self): '''Tests setting and clearing function breakpoints. @@ -114,7 +113,6 @@ class TestVSCode_setFunctionBreakpoints( @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots - @skipIfLinux # test hangs on linux under heavy load @no_debug_info_test def test_functionality(self): '''Tests hitting breakpoints and the functionality of a single -- cgit v1.2.3