From da83e96273527a137f2ebd77cedb920180eab621 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 8 Nov 2019 17:35:52 -0800 Subject: Fix a regression in macOS-style path remapping. When we switched to the LLVM .debug_line parser, the .dSYM-style path remapping logic stopped working for relative paths because of how RemapSourceFile silently fails for relative paths. This patch both makes the code more readable and fixes this particular bug. One interesting thing I learned is that Module::RemapSourceFile() is a macOS-only code path that operates on on the lldb::Module level and is completely separate from target.source-map, which operates on a per-Target level. Differential Revision: https://reviews.llvm.org/D70037 rdar://problem/56924558 --- .../lldbsuite/test/macosx/DBGSourcePathRemapping/Inputs/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Inputs/main.c') diff --git a/lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Inputs/main.c b/lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Inputs/main.c index 556bda3c17d..41a6a46c926 100644 --- a/lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Inputs/main.c +++ b/lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Inputs/main.c @@ -1,8 +1,8 @@ -void stop() {} +void relative(); int main() { - stop(); - // Hello World! + relative(); + // Hello Absolute! return 0; } -- cgit v1.2.3