From fd9a526a30cdb84ee9821e384cf13ec1dccdaf7e Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 4 Dec 2017 13:31:56 +0000 Subject: Makefile.rules: compile all tests with -fno-limit-debug-info Summary: This flag is on by default for darwin and freebsd, but off for linux. Without it, clang will sometimes not emit debug info for types like std::string. Whether it does this, and which tests will fail because of that depends on the linux distro and c++ library version. A bunch of tests were already setting these flags manually, but here instead I take a whole sale approach and enable this flag for all tests. Any test which does not want to have this flag (right now we have one such test) can turn it off explicitly via CFLAGS_EXTRAS+=$(LIMIT_DEBUG_INFO_FLAGS) This fixes a bunch of data formatter tests on red-hat. Reviewers: davide, jankratochvil Subscribers: emaste, aprantl, krytarowski, JDevlieghere, lldb-commits Differential Revision: https://reviews.llvm.org/D40717 llvm-svn: 319653 --- lldb/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile | 2 -- lldb/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile | 7 ------- lldb/packages/Python/lldbsuite/test/lang/cpp/template/Makefile | 2 -- 3 files changed, 11 deletions(-) (limited to 'lldb/packages/Python/lldbsuite/test/lang/cpp') diff --git a/lldb/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile b/lldb/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile index 194af7b3239..314f1cb2f07 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile +++ b/lldb/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile @@ -2,6 +2,4 @@ LEVEL = ../../../make CXX_SOURCES := main.cpp -CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS) - include $(LEVEL)/Makefile.rules diff --git a/lldb/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile b/lldb/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile index f61a6300a99..fe27980afe9 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile +++ b/lldb/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile @@ -5,11 +5,4 @@ CFLAGS := -g -O0 clean: OBJECTS+=$(wildcard main.d.*) -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD -# targets. Other targets do not, which causes this test to fail. -# This flag enables FullDebugInfo for all targets. -ifneq (,$(findstring clang,$(CC))) - CFLAGS_EXTRAS += -fno-limit-debug-info -endif - include $(LEVEL)/Makefile.rules diff --git a/lldb/packages/Python/lldbsuite/test/lang/cpp/template/Makefile b/lldb/packages/Python/lldbsuite/test/lang/cpp/template/Makefile index 194af7b3239..314f1cb2f07 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/cpp/template/Makefile +++ b/lldb/packages/Python/lldbsuite/test/lang/cpp/template/Makefile @@ -2,6 +2,4 @@ LEVEL = ../../../make CXX_SOURCES := main.cpp -CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS) - include $(LEVEL)/Makefile.rules -- cgit v1.2.3