From 5c4c9e61725526e1e7afca87b395a0efd2aeabfd Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 25 Sep 2019 00:36:00 +0000 Subject: Canonicalize variable usage in testsuite Makefiles This test streamlines our use of variables that are expected by Makefile.rules throughout the test suite. Mostly it replaced potentially dangerous overrides and updates of variables like CFLAGS with safe assignments to variables reserved for this purpose like CFLAGS_EXTRAS. Differential Revision: https://reviews.llvm.org/D67984 llvm-svn: 372795 --- lldb/packages/Python/lldbsuite/test/lang/c/blocks/Makefile | 2 +- lldb/packages/Python/lldbsuite/test/lang/c/const_variables/Makefile | 2 +- lldb/packages/Python/lldbsuite/test/lang/c/local_variables/Makefile | 2 +- lldb/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile | 2 +- lldb/packages/Python/lldbsuite/test/lang/c/unicode/Makefile | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) (limited to 'lldb/packages/Python/lldbsuite/test/lang/c') diff --git a/lldb/packages/Python/lldbsuite/test/lang/c/blocks/Makefile b/lldb/packages/Python/lldbsuite/test/lang/c/blocks/Makefile index a90dc493b8c..57083c95274 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/c/blocks/Makefile +++ b/lldb/packages/Python/lldbsuite/test/lang/c/blocks/Makefile @@ -1,4 +1,4 @@ C_SOURCES := main.c -CFLAGS_EXTRAS += -fblocks +CFLAGS_EXTRAS := -fblocks include Makefile.rules diff --git a/lldb/packages/Python/lldbsuite/test/lang/c/const_variables/Makefile b/lldb/packages/Python/lldbsuite/test/lang/c/const_variables/Makefile index 47b3ca4be66..325be90d17e 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/c/const_variables/Makefile +++ b/lldb/packages/Python/lldbsuite/test/lang/c/const_variables/Makefile @@ -1,5 +1,5 @@ C_SOURCES := main.c functions.c -CFLAGS_EXTRAS += -O3 +CFLAGS_EXTRAS := -O3 include Makefile.rules diff --git a/lldb/packages/Python/lldbsuite/test/lang/c/local_variables/Makefile b/lldb/packages/Python/lldbsuite/test/lang/c/local_variables/Makefile index ae2e4c45e11..d3998eeef99 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/c/local_variables/Makefile +++ b/lldb/packages/Python/lldbsuite/test/lang/c/local_variables/Makefile @@ -1,5 +1,5 @@ C_SOURCES := main.c -CFLAGS_EXTRAS += -O1 +CFLAGS_EXTRAS := -O1 include Makefile.rules diff --git a/lldb/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile b/lldb/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile index 569979a0653..e4d42f6525d 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile +++ b/lldb/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile @@ -1,5 +1,5 @@ C_SOURCES := test.c -CFLAGS_EXTRAS += -O1 -D_FORTIFY_SOURCE=0 +CFLAGS_EXTRAS := -O1 -D_FORTIFY_SOURCE=0 include Makefile.rules diff --git a/lldb/packages/Python/lldbsuite/test/lang/c/unicode/Makefile b/lldb/packages/Python/lldbsuite/test/lang/c/unicode/Makefile index db8ac60dd19..a40a666476c 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/c/unicode/Makefile +++ b/lldb/packages/Python/lldbsuite/test/lang/c/unicode/Makefile @@ -1,4 +1,4 @@ C_SOURCES := main.c -CFLAGS_EXTRAS += -finput-charset=UTF-8 -fextended-identifiers -std=c99 +CFLAGS_EXTRAS := -finput-charset=UTF-8 -fextended-identifiers -std=c99 include Makefile.rules -- cgit v1.2.3