From 0d6f681292d5ae8ed5df0cc29eaf95928d264d43 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Mon, 11 Mar 2019 18:16:20 +0000 Subject: Fix a crasher in StackFrame::GetValueForVariableExpressionPath() There was a crash that would happen if an IDE would ask for a child of a shared pointer via any SB API call that ends up calling StackFrame::GetValueForVariableExpressionPath(). The previous code expects an error to be set describing why the synthetic child of a type was not able to be found, but we have some synthetic child providers that weren't setting the error and returning an empty value object shared pointer. This fixes that to ensure we don't lose our debug session by crashing, fully tests GetValueForVariableExpressionPath functionality, and ensures we don't crash on GetValueForVariableExpressionPath() in the future. Differential Revision: https://reviews.llvm.org/D59200 llvm-svn: 355850 --- .../packages/Python/lldbsuite/test/functionalities/var_path/Makefile | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 lldb/packages/Python/lldbsuite/test/functionalities/var_path/Makefile (limited to 'lldb/packages/Python/lldbsuite/test/functionalities/var_path/Makefile') diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/var_path/Makefile b/lldb/packages/Python/lldbsuite/test/functionalities/var_path/Makefile new file mode 100644 index 00000000000..8a7102e347a --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/functionalities/var_path/Makefile @@ -0,0 +1,5 @@ +LEVEL = ../../make + +CXX_SOURCES := main.cpp + +include $(LEVEL)/Makefile.rules -- cgit v1.2.3