From 8243918f43c6eedc2b018c1edc9c6b72fe9b3c1e Mon Sep 17 00:00:00 2001 From: Fred Riss Date: Wed, 6 Nov 2019 13:53:14 -0800 Subject: Testuite: Support Asan test with remote testing To do so, we need to register the sanitizer libraries with the target so that they get uploaded before running. This patch adds a helper to the test class to this effect. --- .../lldbsuite/test/functionalities/asan/TestMemoryHistory.py | 8 ++++---- .../Python/lldbsuite/test/functionalities/asan/TestReportData.py | 9 +++++---- 2 files changed, 9 insertions(+), 8 deletions(-) (limited to 'lldb/packages/Python/lldbsuite/test/functionalities/asan') diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py b/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py index 6b299e6c3b8..6b192b3fc30 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py @@ -17,7 +17,6 @@ class AsanTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) @skipIfFreeBSD # llvm.org/pr21136 runtimes not yet available by default - @skipIfRemote @skipUnlessAddressSanitizer def test(self): self.build() @@ -33,9 +32,10 @@ class AsanTestCase(TestBase): def asan_tests(self): exe = self.getBuildArtifact("a.out") - self.expect( - "file " + exe, - patterns=["Current executable set to .*a.out"]) + target = self.dbg.CreateTarget(exe) + self.assertTrue(target, VALID_TARGET) + + self.registerSanitizerLibrariesWithTarget(target) self.runCmd("breakpoint set -f main.c -l %d" % self.line_breakpoint) diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py b/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py index d523b472b3e..18d99638925 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py @@ -17,7 +17,6 @@ class AsanTestReportDataCase(TestBase): mydir = TestBase.compute_mydir(__file__) @skipIfFreeBSD # llvm.org/pr21136 runtimes not yet available by default - @skipIfRemote @skipUnlessAddressSanitizer @skipIf(archs=['i386'], bugnumber="llvm.org/PR36710") def test(self): @@ -36,9 +35,11 @@ class AsanTestReportDataCase(TestBase): def asan_tests(self): exe = self.getBuildArtifact("a.out") - self.expect( - "file " + exe, - patterns=["Current executable set to .*a.out"]) + target = self.dbg.CreateTarget(exe) + self.assertTrue(target, VALID_TARGET) + + self.registerSanitizerLibrariesWithTarget(target) + self.runCmd("run") stop_reason = self.dbg.GetSelectedTarget().process.GetSelectedThread().GetStopReason() -- cgit v1.2.3