From 8e2f09d61582f8e0ce8481972f47b2e1acd0175c Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Fri, 12 Oct 2018 19:29:59 +0000 Subject: [dotest] Make a missing FileCheck binary a warning, not an error This allows bots which haven't updated to pass in --filecheck to dotest.py to run more tests. FileCheck-dependent tests will continue to fail. Differential Revision: https://reviews.llvm.org/D53175 llvm-svn: 344401 --- lldb/packages/Python/lldbsuite/test/dotest.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'lldb/packages/Python/lldbsuite/test/dotest.py') diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py index ab466288669..e3a30ed5b10 100644 --- a/lldb/packages/Python/lldbsuite/test/dotest.py +++ b/lldb/packages/Python/lldbsuite/test/dotest.py @@ -308,11 +308,15 @@ def parseOptionsAndInitTestdirs(): 'xcrun -find -toolchain default dsymutil') if args.filecheck: - # The CMake build passes in a path to a working FileCheck binary. + # The lldb-dotest script produced by the CMake build passes in a path + # to a working FileCheck binary. So does one specific Xcode project + # target. However, when invoking dotest.py directly, a valid --filecheck + # option needs to be given. configuration.filecheck = os.path.abspath(args.filecheck) - else: - logging.error('No valid FileCheck executable; aborting...') - sys.exit(-1) + + if not configuration.get_filecheck_path(): + logging.warning('No valid FileCheck executable; some tests may fail...') + logging.warning('(Double-check the --filecheck argument to dotest.py)') if args.channels: lldbtest_config.channels = args.channels -- cgit v1.2.3