From 252d7bdc67ec298f91286c02b2ff694673ce7c12 Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Mon, 23 Oct 2017 23:17:53 +0000 Subject: [lldbtests] Handle errors instead of crashing. If you pass an invalid compiler/debugger path on the cmdline to `dotest.py` this is what you get. Traceback (most recent call last): [...] File "dotest.py", line 7, in lldbsuite.test.run_suite() [...] And with the patch applied: /home/davide/work/build-lldb/bin/clandasfasg is not a valid path, exiting Differential Revision: https://reviews.llvm.org/D39199 llvm-svn: 316393 --- lldb/packages/Python/lldbsuite/test/dotest.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'lldb/packages/Python/lldbsuite/test/dotest.py') diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py index 7d739acba95..91f1427136c 100644 --- a/lldb/packages/Python/lldbsuite/test/dotest.py +++ b/lldb/packages/Python/lldbsuite/test/dotest.py @@ -50,7 +50,11 @@ from ..support import seven def is_exe(fpath): - """Returns true if fpath is an executable.""" + """Returns true if fpath is an executable. + Exits with an error code if the specified path is invalid""" + if not os.path.exists(fpath): + print(fpath + " is not a valid path, exiting") + sys.exit(-1) return os.path.isfile(fpath) and os.access(fpath, os.X_OK) -- cgit v1.2.3