From f0c3f68e33c2100d3a298e9bd20f523392a90c61 Mon Sep 17 00:00:00 2001 From: Zachary Turner Date: Fri, 6 Nov 2015 18:14:31 +0000 Subject: Make Windows always use multiprocessing-pool. We still see "Too many file handles" errors on Windows even with lower numbers of cores. It's not clear what the right balance is, and the bar seems to move as more tests get added. So just use the strategy that works until we can investigate more deeply. llvm-svn: 252325 --- lldb/packages/Python/lldbsuite/test/dosep.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'lldb/packages/Python/lldbsuite/test/dosep.py') diff --git a/lldb/packages/Python/lldbsuite/test/dosep.py b/lldb/packages/Python/lldbsuite/test/dosep.py index 08da003e9b5..5bc966d67fd 100644 --- a/lldb/packages/Python/lldbsuite/test/dosep.py +++ b/lldb/packages/Python/lldbsuite/test/dosep.py @@ -1264,11 +1264,10 @@ def default_test_runner_name(num_threads): elif os.name == "nt": # On Windows, Python uses CRT with a low limit on the number of open # files. If you have a lot of cores, the threading-pool runner will - # often fail because it exceeds that limit. - if num_threads > 32: - test_runner_name = "multiprocessing-pool" - else: - test_runner_name = "threading-pool" + # often fail because it exceeds that limit. It's not clear what the + # right balance is, so until we can investigate it more deeply, + # just use the one that works + test_runner_name = "multiprocessing-pool" elif is_darwin_version_lower_than( distutils.version.StrictVersion("10.10.0")): # OS X versions before 10.10 appear to have an issue using -- cgit v1.2.3