From 87bc320b510e91a1a71aa8a154c585db65579628 Mon Sep 17 00:00:00 2001 From: Raphael Isemann Date: Thu, 7 Nov 2019 15:47:01 +0100 Subject: [lldb] Add -m option to 'target modules dump symtab' to disable demangling Summary: This option was added downstream in swift-lldb. This upstreams this option as it seems useful and also adds the missing tests. Reviewers: #lldb, kwk, labath Reviewed By: kwk, labath Subscribers: labath, kwk, abidh, JDevlieghere, lldb-commits Tags: #lldb, #upstreaming_lldb_s_downstream_patches Differential Revision: https://reviews.llvm.org/D69944 --- .../dump-symtab-demangle/TestDumpSymtabDemangle.py | 30 ++++++++++++++++++++++ .../commands/target/dump-symtab-demangle/a.yaml | 18 +++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 lldb/packages/Python/lldbsuite/test/commands/target/dump-symtab-demangle/TestDumpSymtabDemangle.py create mode 100644 lldb/packages/Python/lldbsuite/test/commands/target/dump-symtab-demangle/a.yaml (limited to 'lldb/packages/Python/lldbsuite/test/commands/target/dump-symtab-demangle') diff --git a/lldb/packages/Python/lldbsuite/test/commands/target/dump-symtab-demangle/TestDumpSymtabDemangle.py b/lldb/packages/Python/lldbsuite/test/commands/target/dump-symtab-demangle/TestDumpSymtabDemangle.py new file mode 100644 index 00000000000..9f95a11f387 --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/commands/target/dump-symtab-demangle/TestDumpSymtabDemangle.py @@ -0,0 +1,30 @@ +""" +Test 'target modules dump symtab -m' doesn't demangle symbols. +""" + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + +class TestCase(TestBase): + + mydir = TestBase.compute_mydir(__file__) + + @no_debug_info_test + def test(self): + src_dir = self.getSourceDir() + yaml_path = os.path.join(src_dir, "a.yaml") + yaml_base, ext = os.path.splitext(yaml_path) + obj_path = self.getBuildArtifact("main.o") + self.yaml2obj(yaml_path, obj_path) + + # Create a target with the object file we just created from YAML + target = self.dbg.CreateTarget(obj_path) + self.assertTrue(target, VALID_TARGET) + + # First test that we demangle by default and our mangled symbol isn't in the output. + self.expect("target modules dump symtab", substrs=["foo::bar(int)"]) + self.expect("target modules dump symtab", matching=False, substrs=["_ZN3foo3barEi"]) + + # Turn off demangling and make sure that we now see the mangled name in the output. + self.expect("target modules dump symtab -m", substrs=["_ZN3foo3barEi"]) diff --git a/lldb/packages/Python/lldbsuite/test/commands/target/dump-symtab-demangle/a.yaml b/lldb/packages/Python/lldbsuite/test/commands/target/dump-symtab-demangle/a.yaml new file mode 100644 index 00000000000..ed591d7c1c1 --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/commands/target/dump-symtab-demangle/a.yaml @@ -0,0 +1,18 @@ +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data: ELFDATA2LSB + Type: ET_REL + Machine: EM_X86_64 +Sections: + - Name: .text + Type: SHT_PROGBITS + Flags: [ SHF_ALLOC, SHF_EXECINSTR ] + AddressAlign: 0x0000000000000010 + Content: 554889E5897DFC5DC3 +Symbols: + - Name: _ZN3foo3barEi + Type: STT_FUNC + Section: .text + Size: 0x0000000000000009 +... -- cgit v1.2.3