From 29872606d220420d53fde7cc5e3bea15f8da62e7 Mon Sep 17 00:00:00 2001 From: Raphael Isemann Date: Sun, 1 Sep 2019 09:12:37 +0000 Subject: [lldb] Restructure test folders to match LLDB command hierarchy Summary: As discussed on lldb-dev, this patch moves some LLDB tests into a hierarchy that more closely resembles the commands we use in the LLDB interpreter. This patch should only move tests that use the command interpreter and shouldn't touch any tests that primarily test the SB API. Reviewers: #lldb, jfb, JDevlieghere Reviewed By: #lldb, JDevlieghere Subscribers: dexonsmith, arphaman, JDevlieghere, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D67033 llvm-svn: 370605 --- .../test/commands/settings/quoting/Makefile | 5 ++ .../test/commands/settings/quoting/TestQuoting.py | 94 ++++++++++++++++++++++ .../test/commands/settings/quoting/main.c | 21 +++++ 3 files changed, 120 insertions(+) create mode 100644 lldb/packages/Python/lldbsuite/test/commands/settings/quoting/Makefile create mode 100644 lldb/packages/Python/lldbsuite/test/commands/settings/quoting/TestQuoting.py create mode 100644 lldb/packages/Python/lldbsuite/test/commands/settings/quoting/main.c (limited to 'lldb/packages/Python/lldbsuite/test/commands/settings/quoting') diff --git a/lldb/packages/Python/lldbsuite/test/commands/settings/quoting/Makefile b/lldb/packages/Python/lldbsuite/test/commands/settings/quoting/Makefile new file mode 100644 index 00000000000..0d70f259501 --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/commands/settings/quoting/Makefile @@ -0,0 +1,5 @@ +LEVEL = ../../make + +C_SOURCES := main.c + +include $(LEVEL)/Makefile.rules diff --git a/lldb/packages/Python/lldbsuite/test/commands/settings/quoting/TestQuoting.py b/lldb/packages/Python/lldbsuite/test/commands/settings/quoting/TestQuoting.py new file mode 100644 index 00000000000..441b1cc3c87 --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/commands/settings/quoting/TestQuoting.py @@ -0,0 +1,94 @@ +""" +Test quoting of arguments to lldb commands +""" + +from __future__ import print_function + + + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class SettingsCommandTestCase(TestBase): + + mydir = TestBase.compute_mydir(__file__) + + @classmethod + def classCleanup(cls): + """Cleanup the test byproducts.""" + cls.RemoveTempFile("stdout.txt") + + @no_debug_info_test + def test_no_quote(self): + self.do_test_args("a b c", "a\0b\0c\0") + + @no_debug_info_test + def test_single_quote(self): + self.do_test_args("'a b c'", "a b c\0") + + @no_debug_info_test + def test_double_quote(self): + self.do_test_args('"a b c"', "a b c\0") + + @no_debug_info_test + def test_single_quote_escape(self): + self.do_test_args("'a b\\' c", "a b\\\0c\0") + + @no_debug_info_test + def test_double_quote_escape(self): + self.do_test_args('"a b\\" c"', 'a b" c\0') + + @no_debug_info_test + def test_double_quote_escape2(self): + self.do_test_args('"a b\\\\" c', 'a b\\\0c\0') + + @no_debug_info_test + def test_single_in_double(self): + self.do_test_args('"a\'b"', "a'b\0") + + @no_debug_info_test + def test_double_in_single(self): + self.do_test_args("'a\"b'", 'a"b\0') + + @no_debug_info_test + def test_combined(self): + self.do_test_args('"a b"c\'d e\'', 'a bcd e\0') + + @no_debug_info_test + def test_bare_single(self): + self.do_test_args("a\\'b", "a'b\0") + + @no_debug_info_test + def test_bare_double(self): + self.do_test_args('a\\"b', 'a"b\0') + + def do_test_args(self, args_in, args_out): + """Test argument parsing. Run the program with args_in. The program dumps its arguments + to stdout. Compare the stdout with args_out.""" + self.buildDefault() + + exe = self.getBuildArtifact("a.out") + self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET) + + local_outfile = self.getBuildArtifact("output.txt") + if lldb.remote_platform: + remote_outfile = "output.txt" # Relative to platform's PWD + else: + remote_outfile = local_outfile + + self.runCmd("process launch -- %s %s" %(remote_outfile, args_in)) + + if lldb.remote_platform: + src_file_spec = lldb.SBFileSpec(remote_outfile, False) + dst_file_spec = lldb.SBFileSpec(local_outfile, True) + lldb.remote_platform.Get(src_file_spec, dst_file_spec) + + with open(local_outfile, 'r') as f: + output = f.read() + + self.RemoveTempFile(local_outfile) + + self.assertEqual(output, args_out) diff --git a/lldb/packages/Python/lldbsuite/test/commands/settings/quoting/main.c b/lldb/packages/Python/lldbsuite/test/commands/settings/quoting/main.c new file mode 100644 index 00000000000..2ebaa142bc5 --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/commands/settings/quoting/main.c @@ -0,0 +1,21 @@ +#include +#include +#include + +/* This program writes its arguments (separated by '\0') to stdout. */ +int +main(int argc, char const *argv[]) +{ + int i; + + FILE *output = fopen (argv[1], "w"); + if (output == NULL) + exit (1); + + for (i = 2; i < argc; ++i) + fwrite(argv[i], strlen(argv[i])+1, 1, output); + + fclose (output); + + return 0; +} -- cgit v1.2.3