From 9bace26a690a778ec0f09a9aae9537dfbdb6f42f Mon Sep 17 00:00:00 2001 From: Raphael Isemann Date: Fri, 13 Dec 2019 12:24:23 +0100 Subject: [lldb][NFC] Remove all `setUp` overrides that only call the parent implementation Summary: A lot of our tests copied the setUp code from our TestSampleTest.py: ``` def setUp(self): # Call super's setUp(). TestBase.setUp(self) ``` This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions. Reviewers: labath, JDevlieghere Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71454 --- .../test/commands/expression/calculator_mode/TestCalculatorMode.py | 4 ---- .../lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py | 4 ---- .../lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py | 2 -- .../expression/persistent_ptr_update/TestPersistentPtrUpdate.py | 4 ---- .../test/commands/expression/weak_symbols/TestWeakSymbols.py | 4 ---- 5 files changed, 18 deletions(-) (limited to 'lldb/packages/Python/lldbsuite/test/commands/expression') diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py b/lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py index 29d370e2335..f406066ace0 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py +++ b/lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py @@ -14,10 +14,6 @@ class TestCalculatorMode(TestBase): mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def test__calculator_mode(self): """Test calling expressions in the dummy target.""" self.expect("expression 11 + 22", "11 + 22 didn't get the expected result", substrs=["33"]) diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py b/lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py index 2babcc48cff..825e0be5b69 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py +++ b/lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py @@ -30,10 +30,6 @@ class TestAllowJIT(TestBase): self.main_source_file = lldb.SBFileSpec("main.c") self.expr_options_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def expr_cmd_test(self): (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self, "Set a breakpoint here", self.main_source_file) diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py b/lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py index 56abc19f4f3..b6e6b8ba051 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py +++ b/lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py @@ -30,5 +30,3 @@ class ExprEntryBPTestCase(TestBase): self.assertTrue(result.IsValid(), "Can't evaluate expression") self.assertEqual(8, result.GetValueAsSigned()) - def setUp(self): - TestBase.setUp(self) diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py b/lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py index 54cb4832312..5660113b8b4 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py +++ b/lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py @@ -13,10 +13,6 @@ class PersistentPtrUpdateTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def test(self): """Test that we can have persistent pointer variables""" self.build() diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py b/lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py index 21280ea3ae5..b58d838b14b 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py +++ b/lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py @@ -25,10 +25,6 @@ class TestWeakSymbolsInExpressions(TestBase): self.main_source_file = lldb.SBFileSpec("main.c") self.do_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def run_weak_var_check (self, weak_varname, present): # The expression will modify present_weak_int to signify which branch # was taken. Set it to so we don't get confused by a previous run. -- cgit v1.2.3