From 0d2472ff6f604af842059d9a0098db274515a2d3 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 26 Nov 2019 16:41:26 +0100 Subject: [lldb/IRExecutionUnit] Stop searching based on demangled names Summary: This was causing problems on linux, where we'd end up calling the deleting destructor instead of a regular one (because they have the same demangled name), making a lot of mischief in the process. The only place where this was necessary (according to the test suite, at least) was to call a base structor instead of a complete one, but this is now handled in a more targeted fashion. TestCallOverriddenMethod is now re-enabled as it now passes reliably. Reviewers: teemperor, JDevlieghere Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D70722 --- .../expression/call-overridden-method/TestCallOverriddenMethod.py | 1 - 1 file changed, 1 deletion(-) (limited to 'lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py') diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py b/lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py index 9c25597391d..ddaafaab9fd 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py +++ b/lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py @@ -63,7 +63,6 @@ class ExprCommandCallOverriddenMethod(TestBase): # a vtable entry that does not exist in the compiled program). self.expect("expr d.foo()", substrs=["2"]) - @skipIfLinux # Calling constructor causes SIGABRT @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr43707") def test_call_on_temporary(self): """Test calls to overridden methods in derived classes.""" -- cgit v1.2.3