From 25ddcb4c27fb17a2173cf43159952900a72b3ac4 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Fri, 19 Jun 2015 19:43:43 +0000 Subject: Simplify Pass::perform to take a SimpleFile& instead of unique_ptr& None of the implementations replace the SimpleFile with some other file, they just modify the SimpleFile in-place, so a direct reference to the file is sufficient. llvm-svn: 240167 --- lld/lib/ReaderWriter/CoreLinkingContext.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'lld/lib/ReaderWriter/CoreLinkingContext.cpp') diff --git a/lld/lib/ReaderWriter/CoreLinkingContext.cpp b/lld/lib/ReaderWriter/CoreLinkingContext.cpp index 103fed80458..2f4752bf877 100644 --- a/lld/lib/ReaderWriter/CoreLinkingContext.cpp +++ b/lld/lib/ReaderWriter/CoreLinkingContext.cpp @@ -22,8 +22,8 @@ namespace { class OrderPass : public Pass { public: /// Sorts atoms by position - std::error_code perform(std::unique_ptr &file) override { - SimpleFile::DefinedAtomRange defined = file->definedAtoms(); + std::error_code perform(SimpleFile &file) override { + SimpleFile::DefinedAtomRange defined = file.definedAtoms(); std::sort(defined.begin(), defined.end(), DefinedAtom::compareByPosition); return std::error_code(); } @@ -40,10 +40,8 @@ bool CoreLinkingContext::validateImpl(raw_ostream &) { void CoreLinkingContext::addPasses(PassManager &pm) { for (StringRef name : _passNames) { - if (name.equals("order")) - pm.add(std::unique_ptr(new OrderPass())); - else - llvm_unreachable("bad pass name"); + assert(name == "order" && "bad pass name"); + pm.add(std::unique_ptr(new OrderPass())); } } -- cgit v1.2.3