From 2f8c8d59b2a2694b27ca7b287998fd602dc56539 Mon Sep 17 00:00:00 2001 From: Alexey Samsonov Date: Fri, 19 Dec 2014 21:40:04 +0000 Subject: [Sanitizer] Refactor CommonFlags interface. NFC. Add CommonFlags::SetDefaults() and CommonFlags::ParseFromString(), so that this object can be easily tested. Enforce that ParseCommonFlagsFromString() and SetCommonFlagsDefaults() work only with singleton CommonFlags, shared across all sanitizer runtimes. llvm-svn: 224617 --- compiler-rt/lib/tsan/rtl/tsan_flags.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'compiler-rt/lib/tsan/rtl/tsan_flags.cc') diff --git a/compiler-rt/lib/tsan/rtl/tsan_flags.cc b/compiler-rt/lib/tsan/rtl/tsan_flags.cc index 5dc331f5946..ec74a24b022 100644 --- a/compiler-rt/lib/tsan/rtl/tsan_flags.cc +++ b/compiler-rt/lib/tsan/rtl/tsan_flags.cc @@ -94,7 +94,7 @@ void InitializeFlags(Flags *f, const char *env) { f->second_deadlock_stack = false; CommonFlags *cf = common_flags(); - SetCommonFlagsDefaults(cf); + SetCommonFlagsDefaults(); // Override some common flags defaults. cf->allow_addr2line = true; cf->detect_deadlocks = true; @@ -103,10 +103,10 @@ void InitializeFlags(Flags *f, const char *env) { // Let a frontend override. ParseFlags(f, __tsan_default_options()); - ParseCommonFlagsFromString(cf, __tsan_default_options()); + ParseCommonFlagsFromString(__tsan_default_options()); // Override from command line. ParseFlags(f, env); - ParseCommonFlagsFromString(cf, env); + ParseCommonFlagsFromString(env); // Sanity check. if (!f->report_bugs) { -- cgit v1.2.3