From c48e0873af43eb245cdcca7b9822d2ff8646231c Mon Sep 17 00:00:00 2001 From: Russell Gallop Date: Thu, 10 Oct 2019 10:56:52 +0000 Subject: Revert "[ASan] Do not misrepresent high value address dereferences as null dereferences" As it was breaking bots running sanitizer lint check This reverts r374265 (git b577efe4567f1f6a711ad36e1d17280dd1c4f009) llvm-svn: 374308 --- compiler-rt/lib/sanitizer_common/sanitizer_common.h | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'compiler-rt/lib/sanitizer_common/sanitizer_common.h') diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_common.h b/compiler-rt/lib/sanitizer_common/sanitizer_common.h index 87b8f02b5b7..ad056df387d 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_common.h +++ b/compiler-rt/lib/sanitizer_common/sanitizer_common.h @@ -881,11 +881,6 @@ struct SignalContext { bool is_memory_access; enum WriteFlag { UNKNOWN, READ, WRITE } write_flag; - // In some cases the kernel cannot provide the true faulting address; `addr` - // will be zero then. This field allows to distinguish between these cases - // and dereferences of null. - bool is_true_faulting_addr; - // VS2013 doesn't implement unrestricted unions, so we need a trivial default // constructor SignalContext() = default; @@ -898,8 +893,7 @@ struct SignalContext { context(context), addr(GetAddress()), is_memory_access(IsMemoryAccess()), - write_flag(GetWriteFlag()), - is_true_faulting_addr(IsTrueFaultingAddress()) { + write_flag(GetWriteFlag()) { InitPcSpBp(); } @@ -920,7 +914,6 @@ struct SignalContext { uptr GetAddress() const; WriteFlag GetWriteFlag() const; bool IsMemoryAccess() const; - bool IsTrueFaultingAddress() const; }; void InitializePlatformEarly(); -- cgit v1.2.3