From fc33bcfc4a2f7e4b7410f55f753c7d0c20c75b34 Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Mon, 12 Sep 2011 15:48:15 +0000 Subject: Remove the restriction on module-private friends. Since the friend declaration may be the first declaration, we want the ability to that declaration to be marked module-private. llvm-svn: 139497 --- clang/include/clang/Basic/DiagnosticParseKinds.td | 2 -- clang/lib/Sema/DeclSpec.cpp | 7 ------- clang/test/Modules/module-private.cpp | 4 ++-- 3 files changed, 2 insertions(+), 11 deletions(-) (limited to 'clang') diff --git a/clang/include/clang/Basic/DiagnosticParseKinds.td b/clang/include/clang/Basic/DiagnosticParseKinds.td index 2c8a566719e..0f3b998c653 100644 --- a/clang/include/clang/Basic/DiagnosticParseKinds.td +++ b/clang/include/clang/Basic/DiagnosticParseKinds.td @@ -582,8 +582,6 @@ def err_module_expected_ident : Error< "expected a module name after '__import_module__'">; def err_module_expected_semi : Error< "expected a semicolon name after module name">; -def err_module_private_friend : Error< - "friend cannot be declared __module_private__">; } } // end of Parser diagnostics diff --git a/clang/lib/Sema/DeclSpec.cpp b/clang/lib/Sema/DeclSpec.cpp index 531e7a535a3..bb483cc9b10 100644 --- a/clang/lib/Sema/DeclSpec.cpp +++ b/clang/lib/Sema/DeclSpec.cpp @@ -899,13 +899,6 @@ void DeclSpec::Finish(Diagnostic &D, Preprocessor &PP) { ClearStorageClassSpecs(); } - // A friend cannot be specified as module-private. - if (isFriendSpecified() && isModulePrivateSpecified()) { - Diag(D, ModulePrivateLoc, diag::err_module_private_friend) - << FixItHint::CreateRemoval(ModulePrivateLoc); - ModulePrivateLoc = SourceLocation(); - } - assert(!TypeSpecOwned || isDeclRep((TST) TypeSpecType)); // Okay, now we can infer the real type. diff --git a/clang/test/Modules/module-private.cpp b/clang/test/Modules/module-private.cpp index 849897f7333..44215386226 100644 --- a/clang/test/Modules/module-private.cpp +++ b/clang/test/Modules/module-private.cpp @@ -96,8 +96,8 @@ struct public_class { struct inner_struct; static int static_var; - friend __module_private__ void public_func(); // expected-error{{friend cannot be declared __module_private__}} - friend __module_private__ struct public_struct; // expected-error{{friend cannot be declared __module_private__}} + friend __module_private__ void public_func_friend(); + friend __module_private__ struct public_struct_friend; }; template<> __module_private__ struct public_class::inner_struct { }; // expected-error{{member specialization cannot be declared __module_private__}} -- cgit v1.2.3