From 936c67d3efa32d88d0e9eb0bd6c227a5a92a5db0 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Wed, 24 Apr 2019 09:23:31 +0000 Subject: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path Summary: Include insertion in clangd was inserting absolute paths when the include directory was an absolute path with a double dot. This patch makes sure double dots are handled both with absolute and relative paths. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D60873 llvm-svn: 359078 --- clang/unittests/Lex/HeaderSearchTest.cpp | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'clang/unittests/Lex') diff --git a/clang/unittests/Lex/HeaderSearchTest.cpp b/clang/unittests/Lex/HeaderSearchTest.cpp index b5b0f9a833c..5bcdd9efd17 100644 --- a/clang/unittests/Lex/HeaderSearchTest.cpp +++ b/clang/unittests/Lex/HeaderSearchTest.cpp @@ -100,5 +100,12 @@ TEST_F(HeaderSearchTest, BackSlash) { } #endif +TEST_F(HeaderSearchTest, DotDotsWithAbsPath) { + addSearchDir("/x/../y/"); + EXPECT_EQ(Search.suggestPathToFileForDiagnostics("/y/z", + /*WorkingDir=*/""), + "z"); +} + } // namespace } // namespace clang -- cgit v1.2.3