From b8a705305562a8312e6d63ced9c8237d9fae21f3 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Wed, 10 Sep 2014 04:53:53 +0000 Subject: Unique_ptrify PPCallbacks ownership. Unique_ptr creation stil needs to be moved earlier at some of the call sites. llvm-svn: 217474 --- clang/unittests/Frontend/FrontendActionTest.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'clang/unittests/Frontend/FrontendActionTest.cpp') diff --git a/clang/unittests/Frontend/FrontendActionTest.cpp b/clang/unittests/Frontend/FrontendActionTest.cpp index f9cf06efd34..bdd22bd1810 100644 --- a/clang/unittests/Frontend/FrontendActionTest.cpp +++ b/clang/unittests/Frontend/FrontendActionTest.cpp @@ -111,15 +111,15 @@ struct TestPPCallbacks : public PPCallbacks { }; class TestPPCallbacksFrontendAction : public PreprocessorFrontendAction { - TestPPCallbacks *Callbacks; + std::unique_ptr Callbacks; public: - TestPPCallbacksFrontendAction(TestPPCallbacks *C) - : Callbacks(C), SeenEnd(false) {} + TestPPCallbacksFrontendAction(std::unique_ptr C) + : Callbacks(std::move(C)), SeenEnd(false) {} void ExecuteAction() override { Preprocessor &PP = getCompilerInstance().getPreprocessor(); - PP.addPPCallbacks(Callbacks); + PP.addPPCallbacks(std::move(Callbacks)); PP.EnterMainSourceFile(); } void EndSourceFileAction() override { SeenEnd = Callbacks->SeenEnd; } @@ -140,8 +140,8 @@ TEST(PreprocessorFrontendAction, EndSourceFile) { Compiler.setInvocation(Invocation); Compiler.createDiagnostics(); - TestPPCallbacks *Callbacks = new TestPPCallbacks; - TestPPCallbacksFrontendAction TestAction(Callbacks); + std::unique_ptr Callbacks(new TestPPCallbacks); + TestPPCallbacksFrontendAction TestAction(std::move(Callbacks)); ASSERT_FALSE(Callbacks->SeenEnd); ASSERT_FALSE(TestAction.SeenEnd); ASSERT_TRUE(Compiler.ExecuteAction(TestAction)); -- cgit v1.2.3