From e6565625f456123ad6eb33c84c8100d8f9411192 Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Tue, 9 Feb 2010 07:26:29 +0000 Subject: Migrate the mish-mash of declaration checks in Sema::ActOnUninitializedDecl over to InitializationSequence (with default initialization), eliminating redundancy. More importantly, we now check that a const definition in C++ has an initilizer, which was an #if 0'd code for many, many months. A few other tweaks were needed to get everything working again: - Fix all of the places in the testsuite where we defined const objects without initializers (now that we diagnose this issue) - Teach instantiation of static data members to find the previous declaration, so that we build proper redeclaration chains. Previously, we had the redeclaration chain but built it too late to be useful, because... - Teach instantiation of static data member definitions not to try to check an initializer if a previous declaration already had an initializer. This makes sure that we don't complain about static const data members with in-class initializers and out-of-line definitions. - Move all of the incomplete-type checking logic out of Sema::FinalizeDeclaratorGroup; it makes more sense in ActOnUnitializedDecl. There may still be a few places where we can improve these diagnostics. I'll address that as a separate commit. llvm-svn: 95657 --- clang/test/SemaTemplate/instantiate-declref-ice.cpp | 2 -- 1 file changed, 2 deletions(-) (limited to 'clang/test/SemaTemplate/instantiate-declref-ice.cpp') diff --git a/clang/test/SemaTemplate/instantiate-declref-ice.cpp b/clang/test/SemaTemplate/instantiate-declref-ice.cpp index e4e071dd20d..e88b49447cb 100644 --- a/clang/test/SemaTemplate/instantiate-declref-ice.cpp +++ b/clang/test/SemaTemplate/instantiate-declref-ice.cpp @@ -1,5 +1,4 @@ // RUN: %clang_cc1 -fsyntax-only -verify %s - template struct x { static const int j = i; x* y; @@ -10,7 +9,6 @@ const int x::j; int array0[x<2>::j]; - template struct X0 { static const unsigned value = sizeof(T); -- cgit v1.2.3