From b21dd02e6122542a421fe8569ee96f144eef535b Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Tue, 17 Jul 2012 01:27:33 +0000 Subject: Uninitialized variables: two little changes: * Treat compound assignment as a use, at Jordy's request. * Always add compound assignments into the CFG, so we can correctly diagnose the use in 'return x += 1;' llvm-svn: 160334 --- clang/test/Sema/uninit-variables.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) (limited to 'clang/test/Sema/uninit-variables.c') diff --git a/clang/test/Sema/uninit-variables.c b/clang/test/Sema/uninit-variables.c index 4e3d74b3eaf..9257751e471 100644 --- a/clang/test/Sema/uninit-variables.c +++ b/clang/test/Sema/uninit-variables.c @@ -33,8 +33,8 @@ int test5() { int test6() { int x; // expected-note{{initialize the variable 'x' to silence this warning}} - x += 2; - return x; // expected-warning{{variable 'x' is uninitialized when used here}} + x += 2; // expected-warning{{variable 'x' is uninitialized when used here}} + return x; } int test7(int y) { @@ -489,12 +489,17 @@ int returns_twice() { int compound_assign(int *arr, int n) { int sum; // expected-note {{initialize}} for (int i = 0; i < n; ++i) - sum += arr[i]; - return sum / n; // expected-warning {{variable 'sum' is uninitialized}} + sum += arr[i]; // expected-warning {{variable 'sum' is uninitialized}} + return sum / n; } -void compound_assign_2(int n) { - volatile int ignore; - for (int j = 0; j < n; ++j) - ignore += test1(); // ok +int compound_assign_2() { + int x; // expected-note {{initialize}} + return x += 1; // expected-warning {{variable 'x' is uninitialized}} +} + +int compound_assign_3() { + int x; // expected-note {{initialize}} + x *= 0; // expected-warning {{variable 'x' is uninitialized}} + return x; } -- cgit v1.2.3