From f1958627d9cc6fde9fba025af2ed4c1566d1da04 Mon Sep 17 00:00:00 2001 From: Arpith Chacko Jacob Date: Mon, 1 Feb 2016 16:32:47 +0000 Subject: [OpenMP] Prevent nesting of target constructs within target code execution regions. Summary: This patch enhances Sema to check for the following restriction: OpenMP 4.5 [2.17 Nesting of Regions] If a target, target update, target data, target enter data, or target exit data construct is encountered during execution of a target region, the behavior is unspecified. Reviewers: ABataev Differential Revision: http://reviews.llvm.org/D16758 llvm-svn: 259366 --- clang/test/OpenMP/target_parallel_if_messages.cpp | 39 +++++++++++++++++++++++ 1 file changed, 39 insertions(+) (limited to 'clang/test/OpenMP/target_parallel_if_messages.cpp') diff --git a/clang/test/OpenMP/target_parallel_if_messages.cpp b/clang/test/OpenMP/target_parallel_if_messages.cpp index 00e52d17ad7..e22eb8150af 100644 --- a/clang/test/OpenMP/target_parallel_if_messages.cpp +++ b/clang/test/OpenMP/target_parallel_if_messages.cpp @@ -12,25 +12,45 @@ struct S1; // expected-note {{declared here}} template // expected-note {{declared here}} int tmain(T argc, S **argv) { #pragma omp target parallel if // expected-error {{expected '(' after 'if'}} + foo(); #pragma omp target parallel if ( // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if () // expected-error {{expected expression}} + foo(); #pragma omp target parallel if (argc // expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if (argc)) // expected-warning {{extra tokens at the end of '#pragma omp target parallel' are ignored}} + foo(); #pragma omp target parallel if (argc > 0 ? argv[1] : argv[2]) + foo(); #pragma omp target parallel if (foobool(argc)), if (true) // expected-error {{directive '#pragma omp target parallel' cannot contain more than one 'if' clause}} + foo(); #pragma omp target parallel if (S) // expected-error {{'S' does not refer to a value}} + foo(); #pragma omp target parallel if (argv[1]=2) // expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if (argc argc) // expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if(argc) + foo(); #pragma omp target parallel if(target : // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if(parallel : argc // expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if(target : argc) + foo(); #pragma omp target parallel if(parallel : argc) + foo(); #pragma omp target parallel if(target : argc) if(parallel : argc) + foo(); #pragma omp target parallel if(parallel : argc) if (for:argc) // expected-error {{directive name modifier 'for' is not allowed for '#pragma omp target parallel'}} + foo(); #pragma omp target parallel if(target : argc) if (target :argc) // expected-error {{directive '#pragma omp target parallel' cannot contain more than one 'if' clause with 'target' name modifier}} + foo(); #pragma omp target parallel if(parallel : argc) if (parallel :argc) // expected-error {{directive '#pragma omp target parallel' cannot contain more than one 'if' clause with 'parallel' name modifier}} + foo(); #pragma omp target parallel if(target : argc) if (argc) // expected-error {{expected 'parallel' directive name modifier}} expected-note {{previous clause with directive name modifier specified here}} + foo(); #pragma omp target parallel if(target : argc) if(parallel : argc) if (argc) // expected-error {{no more 'if' clause is allowed}} expected-note {{previous clause with directive name modifier specified here}} expected-note {{previous clause with directive name modifier specified here}} foo(); @@ -39,24 +59,43 @@ int tmain(T argc, S **argv) { int main(int argc, char **argv) { #pragma omp target parallel if // expected-error {{expected '(' after 'if'}} + foo(); #pragma omp target parallel if ( // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if () // expected-error {{expected expression}} + foo(); #pragma omp target parallel if (argc // expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if (argc)) // expected-warning {{extra tokens at the end of '#pragma omp target parallel' are ignored}} + foo(); #pragma omp target parallel if (argc > 0 ? argv[1] : argv[2]) + foo(); #pragma omp target parallel if (foobool(argc)), if (true) // expected-error {{directive '#pragma omp target parallel' cannot contain more than one 'if' clause}} + foo(); #pragma omp target parallel if (S1) // expected-error {{'S1' does not refer to a value}} + foo(); #pragma omp target parallel if (argv[1]=2) // expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if (argc argc) // expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if (1 0) // expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if(if(tmain(argc, argv) // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if(target : // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if(parallel : argc // expected-error {{expected ')'}} expected-note {{to match this '('}} + foo(); #pragma omp target parallel if(parallel : argc) + foo(); #pragma omp target parallel if(target : argc) if (for:argc) // expected-error {{directive name modifier 'for' is not allowed for '#pragma omp target parallel'}} + foo(); #pragma omp target parallel if(target : argc) if (target :argc) // expected-error {{directive '#pragma omp target parallel' cannot contain more than one 'if' clause with 'target' name modifier}} + foo(); #pragma omp target parallel if(parallel : argc) if (parallel :argc) // expected-error {{directive '#pragma omp target parallel' cannot contain more than one 'if' clause with 'parallel' name modifier}} + foo(); #pragma omp target parallel if(target : argc) if (argc) // expected-error {{expected 'parallel' directive name modifier}} expected-note {{previous clause with directive name modifier specified here}} + foo(); #pragma omp target parallel if(target : argc) if(parallel : argc) if (argc) // expected-error {{no more 'if' clause is allowed}} expected-note {{previous clause with directive name modifier specified here}} expected-note {{previous clause with directive name modifier specified here}} foo(); -- cgit v1.2.3