From eb4127ffb5c4111954d04ea25a1cd9fbb18232dd Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Fri, 21 Jul 2017 01:17:49 +0000 Subject: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=... The driver ignores -fsanitize-coverage=... flags when also given -fsanitize=... flags for sanitizer flavors that don't support the coverage runtime. This logic failed to account for subsequent -fno-sanitize=... flags that disable the sanitizer flavors that conflict with -fsanitize-coverage=... flags. Patch by Roland McGrath Differential Revision: https://reviews.llvm.org/D35603 llvm-svn: 308707 --- clang/test/Driver/fsanitize-coverage.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'clang/test/Driver/fsanitize-coverage.c') diff --git a/clang/test/Driver/fsanitize-coverage.c b/clang/test/Driver/fsanitize-coverage.c index b8a9fa60aa8..84d92b2adb6 100644 --- a/clang/test/Driver/fsanitize-coverage.c +++ b/clang/test/Driver/fsanitize-coverage.c @@ -95,3 +95,15 @@ // CLANG-CL-COVERAGE-NOT: unknown argument // CLANG-CL-COVERAGE: -fsanitize-coverage-type=1 // CLANG-CL-COVERAGE: -fsanitize=address + +// RUN: %clang -target x86_64-linux-gnu -fsanitize=safe-stack -fsanitize-coverage=trace-pc-guard %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VS-SAFESTACK +// CHECK-VS-SAFESTACK: -fsanitize=safe-stack +// CHECK-VS-SAFESTACK-NOT: -fsanitize-coverage-trace-pc-guard + +// RUN: %clang -target x86_64-linux-gnu -fsanitize=safe-stack -fsanitize-coverage=trace-pc-guard -fno-sanitize=safe-stack %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-NO-SAFESTACK +// CHECK-NO-SAFESTACK-NOT: error: +// CHECK-NO-SAFESTACK-NOT: warning: +// CHECK-NO-SAFESTACK-NOT: argument unused +// CHECK-NO-SAFESTACK-NOT: unknown argument +// CHECK-NO-SAFESTACK-NOT: -fsanitize=safe-stack +// CHECK-NO-SAFESTACK: -fsanitize-coverage-trace-pc-guard -- cgit v1.2.3