From e2125d82787d20ccbfdd1e24e1835c9101e6ad77 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Mon, 26 Sep 2011 02:14:13 +0000 Subject: Don't print a stray ] at the end of diagnostics. Also remove an obsolete utostr call. llvm-svn: 140511 --- clang/lib/Frontend/TextDiagnosticPrinter.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'clang/lib') diff --git a/clang/lib/Frontend/TextDiagnosticPrinter.cpp b/clang/lib/Frontend/TextDiagnosticPrinter.cpp index 3fd91b2c76f..3c2b84f7c89 100644 --- a/clang/lib/Frontend/TextDiagnosticPrinter.cpp +++ b/clang/lib/Frontend/TextDiagnosticPrinter.cpp @@ -20,7 +20,6 @@ #include "llvm/Support/raw_ostream.h" #include "llvm/Support/ErrorHandling.h" #include "llvm/ADT/SmallString.h" -#include "llvm/ADT/StringExtras.h" #include using namespace clang; @@ -1070,15 +1069,17 @@ static void printDiagnosticOptions(raw_ostream &OS, DiagnosticIDs::getCategoryNumberForDiag(Info.getID()); if (DiagCategory) { OS << (Started ? "," : " ["); + Started = true; if (DiagOpts.ShowCategories == 1) - OS << llvm::utostr(DiagCategory); + OS << DiagCategory; else { assert(DiagOpts.ShowCategories == 2 && "Invalid ShowCategories value"); OS << DiagnosticIDs::getCategoryNameFromID(DiagCategory); } } } - OS << "]"; + if (Started) + OS << ']'; } /// \brief Print the given string to a stream, word-wrapping it to -- cgit v1.2.3