From d14757751f4a6aeee2a7ff473eed2f19a579dbe4 Mon Sep 17 00:00:00 2001 From: Chad Rosier Date: Tue, 26 Mar 2013 23:41:30 +0000 Subject: [driver] Do not generate crash diagnostics if the compilation command failed to execute as the crash will surely reoccur while generating the diagnostics. rdar://13362359 llvm-svn: 178089 --- clang/lib/Driver/Compilation.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'clang/lib') diff --git a/clang/lib/Driver/Compilation.cpp b/clang/lib/Driver/Compilation.cpp index db948a5bfe9..1bff4a3d7a7 100644 --- a/clang/lib/Driver/Compilation.cpp +++ b/clang/lib/Driver/Compilation.cpp @@ -290,11 +290,12 @@ int Compilation::ExecuteCommand(const Command &C, } std::string Error; + bool ExecutionFailed; int Res = llvm::sys::Program::ExecuteAndWait(Prog, Argv, /*env*/0, Redirects, /*secondsToWait*/0, /*memoryLimit*/0, - &Error); + &Error, &ExecutionFailed); if (!Error.empty()) { assert(Res && "Error string set with 0 result code!"); getDriver().Diag(clang::diag::err_drv_command_failure) << Error; @@ -304,7 +305,7 @@ int Compilation::ExecuteCommand(const Command &C, FailingCommand = &C; delete[] Argv; - return Res; + return ExecutionFailed ? 1 : Res; } typedef SmallVectorImpl< std::pair > FailingCommandList; -- cgit v1.2.1